#5793: [with patch, needs work] New algorithm for Max Clique in Graph class 
using
Cython
--------------------------+-------------------------------------------------
 Reporter:  ncohen        |        Owner:  rlm       
     Type:  enhancement   |       Status:  reopened  
 Priority:  minor         |    Milestone:  sage-4.1.1
Component:  graph theory  |   Resolution:            
 Keywords:                |     Reviewer:            
   Author:                |       Merged:            
--------------------------+-------------------------------------------------

Comment(by rlm):

 Replying to [comment:15 ncohen]:
 > By the way, I am not really sure this possibility to change the
 algorithm used to compute the cliquer number is that useful...

 There are plenty of reasons to have two different implementations, and one
 I can think of right off the top of my head is to compare results for
 correctness.

 1. You have removed the input "cliques," which is used by NetworkX. You
 need to put this back in, and mention that it is ignored unless the
 algorithm is "networkx."

 2. The `include '../ext/cliquer.pxd'` line at the beginning of cliquer.pyx
 is not necessary. "include" is a plain text include, and `pxd` files are
 forward declarations, which get automatically included by Cython as long
 as the other part of the filename is the same.

 3. One thing I should have mentioned last round: the three functions
 introduced in cliquer.pyx need to be documented, including some nontrivial
 doctests.

 After all this is done, we should be very close to finished!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5793#comment:17>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to