#16964: Speed up comparisons in QQbar
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  critical           |    Milestone:  sage-6.5
      Component:  number fields      |   Resolution:
       Keywords:  variety qqbar cmp  |    Merged in:
  singular                           |    Reviewers:
        Authors:  Martin von Gagern  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/gagern/16964     |  16f62a2ea8e36bf3ac9f781677e404e01366a594
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by gagern):

 * commit:  297c68ad67657dc0e4c04a362827934a2e8ed17c =>
     16f62a2ea8e36bf3ac9f781677e404e01366a594


Comment:

 I like how you avoid unneccessary minpoly computation. But I think we can
 do better than you did, by not having the intervals span negative and
 positive imaginary parts, but instead considering the absolute value of
 the imaginary part. I did something along these lines, but I now see that
 I'll have to rebase that on your latest forced push…
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=731ec907ee9cdc81bb06d647ebf0be26bd6ba117
 731ec90]||{{{trac #16964: review}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=16f62a2ea8e36bf3ac9f781677e404e01366a594
 16f62a2]||{{{trac #16964: Use absolute value of imaginary part}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16964#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to