#16964: Speed up comparisons in QQbar
-------------------------------------+-------------------------------------
Reporter: gagern | Owner:
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-6.5
Component: number fields | Resolution:
Keywords: variety qqbar cmp | Merged in:
singular | Reviewers: Vincent Delecroix
Authors: Martin von Gagern | Work issues:
Report Upstream: N/A | Commit:
Branch: | 3f4afef46ab6a042cb2678394031cb5c26d89b1a
u/vdelecroix/16964 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* commit: aaf3eb648e1feca6e27c6dd3ffc5fdd9cee98191 =>
3f4afef46ab6a042cb2678394031cb5c26d89b1a
* branch: u/gagern/16964 => u/vdelecroix/16964
* reviewer: => Vincent Delecroix
Comment:
I choose a more meaningful test. Could you have a look?
As a consequence of your changes, we get great improvements on comparing
rationals!!
new timings
{{{
sage: a = QQbar(1/3)
sage: b = QQbar(1/2)
sage: %timeit cmp(a,b)
1000000 loops, best of 3: 881 ns per loop
}}}
old timings
{{{
sage: a = QQbar(1/3)
sage: b = QQbar(1/2)
sage: %timeit cmp(a,b)
10000 loops, best of 3: 34.4 µs per loop
}}}
This is completely crazy.
If you are happy with my changes you can set to positive review.
Vincent
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3f4afef46ab6a042cb2678394031cb5c26d89b1a
3f4afef]||{{{trac #16964: better doctest}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16964#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
