#17798: Create a class for Coxeter matrices and types
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: group theory | Resolution:
Keywords: Coxeter, groups, | Merged in:
matrices, types | Reviewers:
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5484c5d6077138d6ed79d5d19af38c1f1da120ea
public/combinat/coxeter_matrices-17798| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by darij):
Some armchair reviewing (I am not sure if I am up to the actual job): You
replaced the `coxeter_matrix` method on `CartanType_abstract` by a call to
the `CoxeterMatrix` constructor, which is heavily ducktyped; you also
removed the caching. Have you checked for speed regressions? I am also
unhappy with the ducktyping since it is hard to debug. Does it makes sense
to build a custom `from_cartan_type` constructor for `CoxeterMatrix` that
bypasses most of the duckery?
--
Ticket URL: <http://trac.sagemath.org/ticket/17798#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
