#17852: Small cleanup in rings.arith and rings.integer
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/17852 | c7916a76b70e698c278fa1780da16e7d96df2fe9
Dependencies: #16878 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_work => needs_review
Comment:
Replying to [comment:27 chapoton]:
> This looks dubious to me:
> {{{
> - R = parent(n)
> - if R in [int, long]:
> + if isinstance(int, long):
> }}}
If an object `n` is not a Sage Element `parent(n)` returns the type of
`n`.
{{{
sage: parent(3r)
<type 'int'>
sage: parent(Graph())
<class 'sage.graphs.graph.Graph'>
}}}
The code {{{parent(n) in [int,long]}}} is (roughly) equivalent to
{{{type(n) in [int,long]}}}. I find much cleaner to use `isinstance`. If
you do have a use case for which there is a difference, then please tell
me.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/17852#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
