#17920: Reimplement IntegerLists using Polyhedron.integral_points()
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/17920 | 5f81a0a08bed2dc5c73f8f99dd32deafdfb3c9a1
Dependencies: #17937 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:40 jdemeyer]:
> Replying to [comment:39 nthiery]:
> > Please do not change the enumeration order, at least as default
> I disagree with this: the default should be "do not sort, return stuff
in the fastest possible way". Sorting an iterator is very expensive and
should only be done if really needed.
For IntegerList itself, any default is fine, and sorting is certainly
very bad. But for Partitions, Compositions, ... users are really
expecting lexicographic order. Besides, this is only a temporary
solution, and we will switch back to lexicographic once we have a
proper implementation of IntegerListLex.
> Is that really true? The only doctest failures that I saw where
> "obvious" failures where some list order changed, I didn't see
> anything subtle.
That's a point indeed; my feeling is that we have been lucky, although
it could be that some changes w.r.t. MuPAD-Combinat makes the code
less dependent on that feature. I am worried by user's personal code
out there. Well, if you are willing to help those guys ...
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/17920#comment:53>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
