#9439: hyperbolic geometry
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: geometry | Resolution:
Keywords: hyperbolic | Merged in:
geometry, Poincare disc, upper | Reviewers: Johan Bosman, Travis
half plane, Beltrami-Klein, | Scrimshaw, Greg Laun, Frédéric
hyperboloid model, sd35 | Chapoton
Authors: Vincent | Work issues:
Delecroix, Martin Raum, Greg | Commit:
Laun, Travis Scrimshaw | 82cf89e367b6f95cf44fdfb7b040974d4e247f94
Report Upstream: N/A | Stopgaps:
Branch: |
public/geometry/hyperbolic-9439 |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
* reviewer: Johan Bosman, Travis Scrimshaw, Greg Laun, Frederic Chapoton
=> Johan Bosman, Travis Scrimshaw, Greg Laun, Frédéric Chapoton
Comment:
Some of those breakage of pep8 was to make it more readable, but I'm not
opposed to those changes. However I am happy overall with your changes,
and I'm treating your comments as positive review on the previous part.
Also it's okay for long tests to be longer than 1s (at least, you're
testing them), but if they were not marked as `# long time`, then my
philosophy is if they are longer than 2-3s on my machine, then I mark them
as long.
Therefore I'm going to set this to a positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/9439#comment:68>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
