#8678: Improvements for morphisms of ModulesWithBasis
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: nthiery
Type: defect | Status: needs_info
Priority: major | Milestone: sage-6.4
Component: categories | Resolution:
Keywords: homsets, module | Merged in:
morphisms, days64 | Reviewers: Franco Saliola
Authors: Nicolas M. Thiéry | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0d3af4d384a8c756ae59c50023aa5972fcd5b969
u/saliola/categories/module- | Stopgaps:
morphisms-8678 |
Dependencies: #10668, #17160 |
-------------------------------------+-------------------------------------
Changes (by saliola):
* keywords: homsets, module morphisms => homsets, module morphisms, days64
* reviewer: => Franco Saliola
* status: needs_review => needs_info
* commit: 6de563d78fb35a84959f3dfa506329519c5ce962 =>
0d3af4d384a8c756ae59c50023aa5972fcd5b969
Comment:
Here is my review. I pushed some typo fixes, improved some of the
documentation and added a few doctests. Here are a few issues and
questions:
- I don't understand the comment in
``src/sage/categories/finitely_generated_semigroups.py``:
{{{
# TODO: update transitive ideal
}}}
- a couple of doctests include the following line:
{{{
sage: import __main__; __main__.f = f
}}}
can you explain why this is necessary?
- line 1015 of ``src/sage/modules/module_with_basis_morphism.py``: the doc
says this should work over an ring, so perhaps the following is not a
valid assumption?
{{{
c = c / s[j] # the base ring is a field
}}}
- the doctests don't pass, but this seems to be related to #17160
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=0d3af4d384a8c756ae59c50023aa5972fcd5b969
0d3af4d]||{{{8678: typo fixes and some new doctests}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/8678#comment:60>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
