#16659: Decomposition of finite dimensional associative algebras
-------------------------------------+-------------------------------------
       Reporter:  virmaux            |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebra            |   Resolution:
       Keywords:  representation     |    Merged in:
  theory                             |    Reviewers:  Franco Saliola
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/virmaux/t/16659  |  434765db324c0e6da9ddab9dd4b02632d12703f9
   Dependencies:  #11111             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by saliola):

 == General comments ==

 - There are a few fixes needed to make the code conform to the Sage coding
 conventions. Things like proper ReST formatting of the documentation, and
 spaces surrounding operators and comparisons. For example:

  {{{len(res)<2}}} should be {{{len(res) < 2}}}
  {{{listGen==[]}}} should be {{{listGen == []}}}
  {{{map( lambda x: x.lift(), res)}}} should be {{{map(lambda x: x.lift(),
 res)}}}
  ...

 - Can you add a description of the algorithm to the documentation string
 of `_orthogonal_decomposition`? I think it would be helpful to someone
 reading the code to figure out what it is trying to do.

--
Ticket URL: <http://trac.sagemath.org/ticket/16659#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to