#16659: Decomposition of finite dimensional associative algebras
-------------------------------------+-------------------------------------
       Reporter:  virmaux            |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebra            |   Resolution:
       Keywords:  representation     |    Merged in:
  theory                             |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/virmaux/t/16659  |  434765db324c0e6da9ddab9dd4b02632d12703f9
   Dependencies:  #11111             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by saliola):

 == finite_dimensional_algebras_with_basis.py ==

 - the code needs to be cleaned up; for details see
   http://www.sagemath.org/doc/developer/coding_basics.html#documentation-
 strings

 {{{
                  Product of two elements.
                  INPUT::
 }}}
 - insert an extra line here
 - also, change :: to : for INPUT blocks
 {{{
                  INPUT::

                      - ``self``, ``right`` -- two elements
 }}}
 The beginning of descriptions of the inputs is aligned with the I in
 INPUT.
 {{{
                  If B is a SubModuleWithBasis of A, then the
 multiplication law of B is
                  inherited from the multiplication of A.
 }}}
 The Python and Sage objects should be approperiately wrapped : `B`, `A`,
 {{{:class:`SubModuleWithBasis`}}}, ...
 {{{
                  return p.retract( self.lift() * right.lift())
 }}}
 There should be no space after `p.retract(`.


 Delete this line:
 {{{
 # x[i,j] = product_on_basis(x,i).coefficient(j)
 }}}

 Delete these lines:
 {{{
 # Old algorithm:
 +                # mat = matrix(self.base_ring(), [
 +                #        [sum(product_on_basis(x,j).coefficient(i) * c
 +                #            for i in keys for j,c in
 product_on_basis(y,i)) for x in keys]
 +                #            for y in keys ])
 }}}

 Wrap the `A` below in single backticks (for latex output):
 {{{
 Construct the ``side`` A-module generated by ``a``.
 }}}

 There is some redundancy:
 {{{
 +                sage: A =
 FiniteDimensionalAlgebrasWithBasis(QQ).example()
 +                sage: A =
 FiniteDimensionalAlgebrasWithBasis(QQ).example(); A
 }}}

 Add a reference for the algorithm/formula used in `_lift_idempotent`.
 There are other possibilities one could use here. Is it work implementing
 some of these other ones and giving the user a choice between algorithms?

 Does Python / Sage prefer {{{!=}}} to {{{<>}}}?

 to be continued ...

--
Ticket URL: <http://trac.sagemath.org/ticket/16659#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to