#17852: Small cleanup in rings.arith and rings.integer
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/17852 | faf206825e26344ae20fbe41363b00ba4e301c07
Dependencies: #16878 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:78 vdelecroix]:
> Replying to [comment:72 jdemeyer]:
> > Sorry but I still don't like the `binomial` code.
> >
> > In particular, do we really need the coercion there? The arguments `x`
and `m` play a very different role, note that `m` is immediately converted
to an integer anyway.
>
> I am not sure I understand.
I mean this:
{{{
if parent(m) is not P:
from sage.structure.element import get_coercion_model
cm = get_coercion_model()
x,m = cm.canonical_coercion(x,m)
P = parent(x)
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/17852#comment:80>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
