#18048: Bug in GAP conversion of finite field elements
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  critical           |    Milestone:  sage-6.6
      Component:  finite rings       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Peter Bruin        |    Reviewers:  Vincent Delecroix
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/pbruin/18048-gap_finite_field_conversion|  
61b6cb93796bc96ac72ce5eab6ecc46772335538
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * status:  needs_review => positive_review
 * reviewer:   => Vincent Delecroix
 * priority:  major => critical


Comment:

 Hello,

 That's wonderful that you did have a look! I put this to positive review
 as it fixes an important bug (and might hopefully be in sage-6.6).

 On a related note, the code uses a lot of string parsing. This is ugly and
 not very safe. I think that we can get rid of most of it with
 - `Characteristic(z)`: the characteristic of the field
 - `DegreeFFE(z)`: degree of the smallest base field containing the element
 `z`
 - `LogFFE(z,base)`: logarithm in finite field
 I do not like the fact that we need to call `LogFFE` to have access to the
 good power of the generator. If you think about a good solution for that I
 will open an other ticket.

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/18048#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to