#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | 4bcf7dc9ee28539f166c14f973f26401ceb39de3
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by aschilling):
Replying to [comment:188 ncohen]:
> > Since most of the internal state is contained in attributes like
`self.rho`, you should document what these mean (and {{{# list of current
search ranges}}} is not sufficient documentation).
>
> +1 to that. This terminology made it much harder for me to understand
what the code was doing. Instead of writing this in the code:
>
> {{{
> self.rho = [] # list of current search ranges
> self.mu = [] # list of integers
> self.j = -1 # index of last element of mu
> self.nu = 0 # sum of values in mu
> }}}
>
> It would probably be clearer to rename those variables (respectively) as
> {{{
> self._search_range
> self._current_list
> self._j
> self._current_sum
> }}}
Fixed.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=fd645e4135e0af8c70fed0d6580cf8ec3e9e20c2
fd645e4]||{{{17979 changed names of iterator attributes}}}||
||[http://git.sagemath.org/sage.git/commit/?id=39ee52d817c0b10ad5795cc2b138a4a83475fc25
39ee52d]||{{{17979: proper specification of the trailing zeroes
'feature'}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4bcf7dc9ee28539f166c14f973f26401ceb39de3
4bcf7dc]||{{{Merge branch 'public/ticket/17979' of
git://trac.sagemath.org/sage into public/ticket/17979}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:206>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
