#18068: Fix ModularForm_abstract.__ne__()
-------------------------------------+-------------------------------------
       Reporter:  pbruin             |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.6
      Component:  modular forms      |   Resolution:
       Keywords:  modular forms      |    Merged in:
  comparison                         |    Reviewers:
        Authors:  Peter Bruin        |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  f65bb00f9f3b5b37637ebb67e0cbefa56026078a
  u/pbruin/18068-modular_form_comparison|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jj):

 While you're at it:

 {{{__cmp__}}} doesn't make any sense at all to me (see the except part):
 {{{
         try:
             self._ensure_is_compatible(other)
         except Exception:
             return self.parent().__cmp__(other.parent())
         if self.element() == other.element():
             return 0
         else:
             return -1
 }}}

 Also {{{__cmp__}}} is getting deprecated and "<,<=,>,>=" aren't needed
 anyway for elements I assume.
 What about also removing {{{__cmp__}}}?

--
Ticket URL: <http://trac.sagemath.org/ticket/18068#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to