#18068: Fix and simplify comparison of modular forms
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: modular forms | Resolution:
Keywords: modular forms | Merged in:
comparison | Reviewers:
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | af4ae72023545ce14eedf32fcdac0d969ef6dd9b
u/pbruin/18068-modular_form_comparison| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Description changed by pbruin:
Old description:
> In Sage 6.6.rc1:
> {{{
> sage: f = Newforms(Gamma1(30), 2, names='a')[1]
> sage: g = loads(dumps(f))
> sage: f == g
> True
> sage: f != g
> True # should be False
> }}}
> This is fixed by implementing `ModularForm_abstract.__ne__()`.
New description:
In Sage 6.6.rc1:
{{{
sage: f = Newforms(Gamma1(30), 2, names='a')[1]
sage: g = loads(dumps(f))
sage: f == g
True
sage: f != g
True # should be False
}}}
This is fixed by implementing `ModularForm_abstract.__ne__()`.
We also remove the (partial) implementation of `__cmp__()` and replace it
by `__eq__()` and `__ne__()`; this simplifies the code and anticipates the
removal of `cmp()` in Python 3.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/18068#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
