#14239: symbolic radical expression for algebraic number
-------------------------------------+-------------------------------------
Reporter: gagern | Owner: davidloeffler
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.5
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Martin von | Reviewers: Marc Mezzarobba,
Gagern, Jeroen Demeyer | Jeroen Demeyer, Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/gagern/ticket/14239 | 4626286463c734f931ecc7405285dc7bc1b58772
Dependencies: #17495, #16964 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => positive_review
* reviewer: Marc Mezzarobba, Jeroen Demeyer => Marc Mezzarobba, Jeroen
Demeyer, Vincent Delecroix
Comment:
Replying to [comment:105 gagern]:
> Replying to [comment:101 vdelecroix]:
> > Instead of `embedding.im_gens()[0]` you can use the clearer
`embedding.gen_image()`.
>
> That won't work: at that point (since the `refine_embedding` line a bit
above that), the object in question is a
`morphism.NumberFieldHomomorphism_im_gens` and not a
`number_field_morphisms.NumberFieldEmbedding` any more, so it doesn't have
a `gen_image` method. I have no idea whether that's how it should be, but
I'm fairly certain that if this should change, some other ticket should
take care of that.
>
> So I'm back to asking for review, even though I changed nothing.
That's good to me!
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/14239#comment:106>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
