#18107: The codes collection should be a real module
-------------------------------------+-------------------------------------
Reporter: jsrn | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.6
Component: coding theory | Resolution:
Keywords: sd66 | Merged in:
Authors: Johan S. R. | Reviewers: Nathann Cohen
Nielsen | Work issues:
Report Upstream: N/A | Commit:
Branch: | f4604893e1757420d61372d22f33c900ca6a316c
u/jsrn/18107_coding_module | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yoooooooo !
> Ok, thanks for the tips Nathann. I didn't really know how the community
felt about rewriting history. If I do a rebase after pushing to the public
branch (which was the case here), I run the risk (afaik) of breaking other
people's synchronisation to the branch (i.e. you). That could cause some
annoyances. Before doing any public pushes, it can make complete sense to
clean up history, as you say. I use "--amend" all the time ;-) (through
magit in Emacs btw).
Well, personally I do not mind. Most of the time you know rathe well
whether anybody is already using your commits and there are not many risks
anyway. Plus in case or problems (=I never met any) it is still
straightforward to cherry-pick commits from the old branch to the new. On
the other hand, I prefer to give reviewers a better picture of what the
code does, plus the branch that will actually become part of Sage will be
cleaner as a result!
Have fuuuuuuuuun,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18107#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
