#18107: The codes collection should be a real module
-------------------------------------+-------------------------------------
Reporter: jsrn | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.6
Component: coding theory | Resolution:
Keywords: sd66 | Merged in:
Authors: Johan S. R. | Reviewers: Nathann Cohen
Nielsen | Work issues:
Report Upstream: N/A | Commit:
Branch: | f4604893e1757420d61372d22f33c900ca6a316c
u/jsrn/18107_coding_module | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Yooooooooooooo !
The code looks good -> positive review.
About your branch: as you can see there are 5 commits, most of which undo
what the others add. There is a very useful command in git which is 'git
rebase -i': it lets you 'merge' several commits into one.
https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-
rewriting-history
You may also find `git commit --amend` useful.
No problem for this branch: let's get it in as it is. I only give those
links as they did prove helpful in my own experience to make easier-to-
read branches (even a posteriori, i.e. after all code has been written).
Cheers,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18107#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
