#18126: Coin-OR CBC: new-style SPKG
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: packages: | Resolution:
optional | Merged in:
Keywords: sd66 | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: public/18126 | 4e3830fbf8c6c7d72ba6f0cdf44ee761bc203a2a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello,
> - The changes made on the source code should better be in a separate
patch file rather than a `sed` command within the `spkg-install` script
(so that one can easily see what changed from upstream in a uniform way).
The associated comment should be part of the patch, see #17357
The `spkg-install` file is a pure copy of what the spkg already contains.
> - I do not see the point of `spkg-src` : since there is no change made
in the tarball, why not just keep the upstream `Cbc-2.9.4.tgz` file and
rename it `cbc-2.9.4.tar.gz` without any modification and put the link
http://www.coin-or.org/download/source/Cbc/Cbc-2.9.4.tgz in the ticket
description ?
Because I believe that we need .tar.bz2 files in upstream. There is no
other reason.
> - "SPKG Maintainers" field is no longer required, see
https://groups.google.com/forum/?fromgroups#!searchin/sage-
devel/spkg$20maintainers/sage-devel/-MZAvj8qxVk/EdbRFw0hGucJ
http://thread.gmane.org/gmane.comp.mathematics.sage.devel/75324
I don't mind. I will remove it in a second and set the patch to
`needs_review` again, waiting for your answer about the first two points.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18126#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
