#18114: Automaton: method to create a transducer out of it
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.6
      Component:  finite state       |   Resolution:
  machines                           |    Merged in:
       Keywords:  sd66               |    Reviewers:  Clemens Heuberger
        Authors:  Daniel Krenn       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/dkrenn/fsm       |  ebe8c7b0b5cd7f5adedd9228d8e3d82045310423
  /automaton-to-transducer           |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by cheuberg):

 * status:  needs_review => needs_work
 * reviewer:   => Clemens Heuberger


Comment:

 I am not convinced that the name of the function is the best choice
 because `A.transducer()` might be thought to do the same thing as
 `Transducer(A)`, but this is not the case:
 {{{
 sage: A = Automaton([(0, 0, 'A'), (0, 1, 'B'), (1, 2, 'C')])
 sage: Transducer(A).transitions()
 [Transition from 0 to 0: 'A'|-,
  Transition from 0 to 1: 'B'|-,
  Transition from 1 to 2: 'C'|-]
 sage: A.transducer().transitions()
 [Transition from 0 to 0: 'A'|'A',
  Transition from 0 to 1: 'B'|'B',
  Transition from 1 to 2: 'C'|'C']
 }}}

 A few minor remarks:
 * There seems to be an indentation problem in the INPUT section of the
 docstring leading to unwanted wrapping in the html output.
 * In view of the [https://groups.google.com/d/msg/sage-
 devel/RfJIEL79EnA/peSruqCwAG4J recent discussion] on "SEE ALSO" sections,
 I recommend to include a link to `input_projection` and to the
 construction of a transducer from a given finite state machine.
 * According to the
 [http://www.sagemath.org/doc/developer/coding_basics.html#the-docstring-
 of-a-function-content develeoper guide], the one sentence description
 should be "Construct ..." instead of "Constructs ...".

--
Ticket URL: <http://trac.sagemath.org/ticket/18114#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to