#17285: CIF is missing many functions
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.6
      Component:  basic arithmetic   |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:  Jeroen Demeyer
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/17285                 |  3f8cd4178d279dbb6e5ad87c3f4a1c9f5ac75548
   Dependencies:  #17130             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 I like the new code. However, a few comments:
 - move the {{{# cos(x + yi) = ... }}} comments inside the docstring as an
 `ALGORITHM:` block.
 - move the `mpfi_init2()` and `mpfi_clear()` outside the
 `sig_on()`/`sig_off()` (it's not really wrong to put them inside, but it's
 certainly safer outside)

--
Ticket URL: <http://trac.sagemath.org/ticket/17285#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to