#18099: Prepare linear_code for inheritance
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: coding theory | Resolution:
Keywords: sd66 | Merged in:
Authors: David Lucas | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dlucas/prepare_linear_code_for_inheritance|
8905552948a0896a46e587815cce539b6e60aae9
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Hello,
I just had a quick look.
1. What is the point of having two classes `AbstractLinearCode` and
`LinearCode`. I would naturally name `LinearCode` the one from which I
need to inherit from. Why not `LinearCode` and `LinearCode_generic`
instead?
2. Why the ambient vector space is not part of the input of
`AbstractLinearCode`?
3. What is the difference between `base_ring` provided by the Module and
`base_field`?
4. Coud you include in the docstring of the former `AbstractLinearCode`:
- the set of attributes that are provided by the class
- what should be done to implement a linar code when inheriting from it
In particular, some methods of `AbstractLinearCode` assume the presence
of the attribute `._generator_matrix` (like `__cmp__`).
5. Could you remove
{{{
+ # sage: C.minimum_distance_upper_bound() # optional (net connection)
+ # 3
+ # sage: C.minimum_distance_why() # optional (net connection)
+ # Ub(7,4) = 3 follows by the Griesmer bound.
}}}
6. In the docstring of `AbstractLinearCode` replace {{{from this abstract
method.}}} with {{{from this abstract class.}}}.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18099#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
