#16352: TransitiveIdeal -> RecursivelyEnumeratedSet in the sage library
-------------------------+-------------------------------------------------
Reporter: | Owner:
slabbe | Status: needs_review
Type: | Milestone: sage-6.4
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: sd66 | Commit:
Authors: | 67e950df6d8ad3d35d3bac1113cba4091ef3fbf1
Report Upstream: N/A | Stopgaps:
Branch: |
u/slabbe/16352 |
Dependencies: |
-------------------------+-------------------------------------------------
Description changed by slabbe:
Old description:
> `TransitiveIdeal` and `TransitiveIealGraded` are used in the code of
> `sage/combinat`, `sage/categories` and `sage/groups` at least. These
> should be replaced by `RecursivelyEnumeratedSet` for speed improvements
> and also to avoid issues explained in #6637.
>
> This is a follow up of #6637 where `TransitiveIdeal` and
> `TransitiveIealGraded` have been deprecated.
>
> More precisely, occurences of
>
> `TransitiveIdeal(succ, seeds)`
> `TransitiveIdealGraded(succ, seeds, max_depth)`
>
> are replaced (respectively) by:
>
> `RecursivelyEnumeratedSet(seeds, succ, structure=None,
> enumeration='naive')`
> `RecursivelyEnumeratedSet(seeds, succ, structure=None,
> enumeration='breadth', max_depth=max_depth)`
>
> Indeed, deprecated `TransitiveIdealGraded` class was not using the
> hypothesis of being graded in its code. This is why the structure is set
> to `None` for now. Of course, if people have *really* a graded structure,
> then the structure argument should be set to `'graded'`... For now, I am
> keeping the behavior like it was before to avoid problems and also
> because it seems that `TransitiveIdealGraded` was used in places where
> the structure was not graded...
New description:
`TransitiveIdeal` and `TransitiveIealGraded` are used in the code of
`sage/combinat`, `sage/categories` and `sage/groups` at least. These
should be replaced by `RecursivelyEnumeratedSet` for speed improvements
and also to avoid issues explained in #6637.
This is a follow up of #6637 where `TransitiveIdeal` and
`TransitiveIealGraded` have been deprecated.
More precisely, occurences of
`TransitiveIdeal(succ, seeds)`
`TransitiveIdealGraded(succ, seeds, max_depth)`
are replaced (respectively) by:
`RecursivelyEnumeratedSet(seeds, succ, structure=None,
enumeration='naive')`
`RecursivelyEnumeratedSet(seeds, succ, structure=None,
enumeration='breadth', max_depth=max_depth)`
Indeed, deprecated `TransitiveIdealGraded` class was not using the
hypothesis of being graded in its code. This is why the structure is set
to `None` for now. Of course, if people have *really* a graded structure,
then the structure argument should be set to `'graded'`... For now, I am
keeping the behavior like it was before and I am assuming the structure is
not graded.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/16352#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
