#18142: Numpy: fix dependency checking of headers
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.6
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Jeroen Demeyer     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  d9bbc1d673590fcd18db88120ac95c68a25f281a
  u/jdemeyer/ticket/18142            |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by fbissey):

 After inspection of my system I got one header that is shared between
 version of python under `/usr/include`: `pygobject/pygobject.h`. There is
 only one switch inside that depends on the version of python used if I
 read the thing correctly. So it can be done.

 Anyway the patch looks very good to me and it get the right head counts of
 `numpy_depends` (26) in `module_list.py`.

 The only thing you forgot is that bit of code in `sage/misc/cython.py`
 {{{
 include_dirs = [os.path.join(SAGE_LOCAL,'include','csage'),
                 os.path.join(SAGE_LOCAL,'include'), \
 
os.path.join(SAGE_LOCAL,'include','python'+platform.python_version().rsplit('.',
 1)[0]), \
                 os.path.join(SAGE_LOCAL,'lib','python','site-
 packages','numpy','core','include'), \
                 os.path.join(SAGE_SRC,'sage','ext'), \
                 os.path.join(SAGE_SRC), \
                 os.path.join(SAGE_SRC,'sage','gsl')]
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/18142#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to