#17979: Reimplementation of IntegerListsLex
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: blocker | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64 | Merged in:
Authors: Bryan Gillespie, | Reviewers: Nathann Cohen, Jeroen
Anne Schilling, Nicolas M. Thiery | Demeyer, Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/17979 | 2e38ce42d71d3dfdf6ea8777cbf8c65b52c25612
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:445 ncohen]:
> > Nathann, is this OK for you?
I believe deciding on API changes like this is going beyond the scope
of this ticket; we are taking decisions in a rush on things that are
debatable (see the discussion with Vincent). But oh well, let's move
on. Thanks Jeroen for taking action toward some state that is
acceptable to everyone.
> I would have changed the calls to make them use
`DisjointUnionEnumeratedSet` directly, but if you think that this deserves
a function then no proble.
I really would much prefer a direct use of DisjointUnionEnumeratedSet,
in particular to set an example for others that would need a similar
feature.
Also, I spent a good deal of time working on documentation and tests
that were just wiped out by this commit. The right thing to do is to
recycle them whenever this can be useful, and at the very least adapt
the tests. I'll work on this now.
Cheers,
Nicolas
PS: It's Pycon today; I'll see what I can do to handle the remaining
comments by Nathann. In the mean time, it would be helpful if we could
get comments on the rest (lookahead, Envelope, ...).
--
Ticket URL: <http://trac.sagemath.org/ticket/17979#comment:449>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
