#18032: Broken copy, plot in sandpile
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: graph theory | Resolution:
Keywords: sd66 | Merged in:
Authors: Peter Wicks | Reviewers: Nathann Cohen
Stringfield, Volker Braun | Work issues:
Report Upstream: N/A | Commit:
Branch: | c500bfa13492c6c51ea52a5b9c0b91fe7b47806a
u/vbraun/ticket/18032 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
> Thats not an improvement since `plot()` still calls `G.copy()` (which
shouldn't have been called copy) instead of `G.__copy__()` to make a
copy.
I agree. Which totally proves that the problem is not that `__copy__`
takes arguments, but that you inherit a function which you overwrite while
accepting fewer arguments.
I think that the easiest is to accept `**kwds` in your copy function and
to forward it to the constructor. Same in the constructor, which will
forward everything to `Graph.__init__`.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18032#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
