#18099: Prepare linear_code for inheritance
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.6
Component: coding theory | Resolution:
Keywords: sd66 | Merged in:
Authors: David Lucas | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dlucas/prepare_linear_code_for_inheritance|
afc9fce253e82eb3f57041bb1ed3c0691e35881f
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_work => needs_info
Comment:
Replying to [comment:31 jsrn]:
> Also, as David mentions, it is really important for
> us that the generator matrix is not explicitly calculated except when
asked for
> (possibly indirectly) by the user. If inheriting
`FreeModule_submodule_field`
> would require us to explicitly calculate the generator matrix, I down-
vote that
> solution. This whole discussion needs to be thought through properly in
another ticket.
All right. Then, I do not understand why there are so much methods in
`AbstractLinearCode`. If most of them need the `generator_matrix` why not
put them in your current `LinearCode` class? I really do not like the fact
that most methods of `AbstractLinearCode` just reimplement the logic of
`FreeModule_submodule_field` using `generator_matrix`.
I would be happy if you briefly explain your reasons to avoid the
construction of one generator matrix in the constructor.
sided note: there are some trailing whitespaces that needs to be removed.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18099#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
