#18099: Prepare linear_code for inheritance
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.6
Component: coding theory | Resolution:
Keywords: sd66 | Merged in:
Authors: David Lucas | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dlucas/prepare_linear_code_for_inheritance|
afc9fce253e82eb3f57041bb1ed3c0691e35881f
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dlucas):
>when you are done with your corrections, you should switch the state to
needs_review. That way, you have a chance that a reviewer comes back and
the patch bot to test your ticket.
I thought I did it. My bad.
>I would be happy if you briefly explain your reasons to avoid the
construction of one generator matrix in the constructor.
Sure. A generator matrix is not mandatory to perform operations of
subfamilies of liner codes. For instance, with Reed-Solomon codes, you can
encode and decode without using a generator matrix at all (in that case,
you work with polynomials only). Compute a generator matrix can take some
time for specific codes, and takes space in memory. If any code needs to
compute a generator matrix in its constructor, that means you force the
user to run a time- and memory-consuming every time he builds a code, even
if he does not want to use it to encde and decode.
According to us, building such a matrix should be a choice for the user as
it is not a "free" computation. Of course, you need a generator for
"generic" linear codes, that's why it is in `LinearCode` class
constructor. But as it is not needed for subfamilies, we prefer not put it
a a parameter of the abstract class constructor.
>sided note: there are some trailing whitespaces that needs to be removed.
Ok, I'll do that
--
Ticket URL: <http://trac.sagemath.org/ticket/18099#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
