#18025: SkewTableau.rectify() optimization
-------------------------------------+-------------------------------------
Reporter: MariaMonks | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: days64, tableau | Merged in:
Authors: Maria Monks | Reviewers: Josh Swanson
Gillespie, Oliver Pechenik | Work issues:
Report Upstream: N/A | Commit:
Branch: | 9785351a4006977fb21a65f25c6245e77f7acb4a
u/opechenik/skew_rectify | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jpswanson):
@darij: yes, I had intended that to be a review (hence the reviewers
change), since I had looked through the code, checked for basic
reasonability, and run the combanat doctests. I also ended up making to my
mind small cleanup changes that themselves needed to be reviewed. Perhaps
because I ended up making nearly as many changes as the original I
shouldn't have set myself as reviewer quite yet?
As for words, I agree with darij's most recent suggestion, except it
should probably be a generator rather than a list comprehension (parens
rather than square brackets). It seems that in practice this is what you'd
want to use most of the time anyway. How does adding an `iter_word` or
`word_iter` (any preference on name?) method to `SkewTableau` sound? It
would just yield from your iterator. I'll probably add such a thing during
tableaux cleanup regardless, but that's a ways off.
--
Ticket URL: <http://trac.sagemath.org/ticket/18025#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
