#18025: SkewTableau.rectify() optimization
-------------------------------------+-------------------------------------
       Reporter:  MariaMonks         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  combinatorics      |   Resolution:
       Keywords:  days64, tableau,   |    Merged in:
  days67                             |    Reviewers:  Josh Swanson
        Authors:  Maria Monks        |  Work issues:
  Gillespie, Oliver Pechenik         |       Commit:
Report Upstream:  N/A                |  94af4b0cf84d244d96b5bd3dcd65a572687cbb67
         Branch:                     |     Stopgaps:
  public/ticket/18025                |
   Dependencies:  #18024             |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * dependencies:   => #18024


Comment:

 I don't quite like the `as_word` argument as you start mucking with the
 output type. I think the better thing to do would be to either explicitly
 factor out the `to_word` to `to_flat_list` and have
 {{{!#python
 def to_word(self):
     return Word(self.to_flat_list())
 }}}
 or just call `[x for row in self for x in row if x is not None]` instead
 of `self.to_word()`. My personal preference is the second option since it
 is a one-liner with the (nested list comprehension).

--
Ticket URL: <http://trac.sagemath.org/ticket/18025#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to