#17662: Evenly distributed sets
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Vincent Delecroix  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/17662       |  3aae6682c3fd3c4abea98d19bcdcf389ca6f8297
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Helloooooooooooo,

 For the moment it's only about form, but:

 - In the desription of the EDS database that appear as a comment in
   `databases.py`: could you give it a better shape with lists and items?
   Something like:

       At position `[k][q]` there is:

       - False: no such set exists

       - (None, B) -- explanation

       - (polynomial, B) -- explanation

   It is a bit hard to read, as it is.

 - can you also call `del` on `R,ZZ` and `a`?

 - In the module doc of `database.py`, could you add a link toward a
 definition
   of `EDS`? From typing this in Google you don't get much.

 - {{{cdef class EvenlyDistributedSets(object):}}} why do you inherit from
   `object`? What do you earn? `O_o`

 - Jeroen's talk at Liege taught us that `check_malloc` existed `:-P`

   http://fossies.org/linux/sage/src/sage/ext/memory.pxd#l_97

 - An ÌNPUT section is missing from at least two functions of your new
 file. In
   particular, it would be cool to know how exactly one is meant to build a
   `EvenlyDistributedSets` instance.

 - About the name `EvenlyDistributedSets`... I don't find it overly
 specific. I
   know that the 's' means 'many', but welll....

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17662#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to