#17662: Evenly distributed sets
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Vincent Delecroix  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/17662       |  d3385807832a91a2a2171aeb9548059a672b5a59
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 While reviewing this code

 {{{
     # PYTHON DATA
     cdef K                       # the underlying field
     cdef list list_K             # the elements of K  (i -> x)
     cdef dict K_to_int           # inverse of list_K  (x -> i)

     # FLAGS
     cdef int count               # do we count or do we iterate
     cdef int check               # do we need to check (debug)
     cdef int up_to_isom          # do we care only about isomorphisms

     # STATIC DATA
     cdef unsigned int q          # cardinality of the field
     cdef unsigned int k          # size of the subsets
     cdef unsigned int e          # k(k-1)/2
     cdef unsigned int ** diff    # qxq array: diff[x][y]  = x - y
     cdef unsigned int ** ratio   # qxq array: ratio[x][y] = x / y

     # DYNAMIC DATA
     cdef unsigned int * B        # current stack of elements of
 {0,...,q-1}
     cdef unsigned int * cosets   # cosets of differences of elts in B
     cdef unsigned int * t        # temporary variable for updates
 }}}

 Thank you for that. This is the kind of code that is a pleasure to read!
 `:-PPPPP`

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/17662#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to