#18152: Universal Cyclotomic Field implementation using libgap
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  number fields      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/18152                 |  e4a352468cf9c018b9bdf148a3de03793a111b9e
   Dependencies:  #18153             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by stumpc5):

 Hi there!

 I kind of feel bad that you plan to remove that much code I wrote in weeks
 of work -- but I guess that's the way it goes if there is something
 better...

 Anyway my first question would be whether it is really desired to remove
 an algorithm from Sage and instead use the same algorithm from Gap? Don't
 you think that working on the cython part of my implementation (maybe even
 moving to plain C of some core functionality) could get it beyond the
 speed of the black box (from a Sage point of view) Gap implementation?

 Secondly, I remember that I did quite some tests back when I implemented
 the UCF. And that in the end, the Sage implementation was slower on some
 parts, while faster on others (one I remember were Sage was quicker was
 the computation of the Galois conjugates of big elements, in case you want
 to test, one example might be {{{E( 2^11 * 3^4 )}}}). I would really like
 to redo these tests, but haven't yet been able to get your branch running
 on my computer. I will get back once that worked out.

 I also remember to have found a few bugs in the Gap implementation while
 implementing UCFs in Sage. That would also not be possible anymore when
 only relying on the implementation in Gap.



 Cheers, Christian

--
Ticket URL: <http://trac.sagemath.org/ticket/18152#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to