#11111: More support for finite dimensional modules and algebras with basis
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:  nthiery
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  categories         |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Florent Hivert,    |    Reviewers:
  Franco Saliola, Nicolas M. ThiƩry  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  25881cc50c7e44b581aba8e7ac67cada770eb7a7
  
public/11111-more_support_for_finite_dimensional_modules_and_algebras_with_basis|
     Stopgaps:
   Dependencies:  #8678, #16925      |
-------------------------------------+-------------------------------------

Comment (by saliola):

 Replying to [comment:70 nthiery]:
 > Replying to [comment:65 saliola]:
 > > 2. `categories/finite_dimensional_modules_with_basis.py`: the
 docstring of `quotient_module` talks about quotient "free" module. What do
 you mean by free?
 >
 > I agree, the phrasing is not great. The point that needs to be
 > highlighted is that this only handles quotients by free submodules
 > admitting a unitriangular row echelon form, so that the quotient is
 > again a free module. Any proposition of rewording is welcome!

 I tweaked it a bit, using what you wrote here.

 > > 3. `categories/semisimple_algebras.py`: what do you mean by "TODO:
 trivial implementations for semisimple_quotient"
 >
 > Err, good point, I don't really know. I guess all the methods that
 > become trivial in this category, like is_semisimple, ... Maybe we can
 > just remove this comment.

 Removed.

 > Running long tests now.

 Positive review, provided that all doctests pass.

--
Ticket URL: <http://trac.sagemath.org/ticket/11111#comment:72>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to