#11111: More support for finite dimensional modules and algebras with basis
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: categories | Resolution:
Keywords: | Merged in:
Authors: Florent Hivert, | Reviewers:
Franco Saliola, Nicolas M. Thiéry | Work issues:
Report Upstream: N/A | Commit:
Branch: | a476501f8ecfa8784cb7a8a6dfc3d4196f5fe53c
public/11111-more_support_for_finite_dimensional_modules_and_algebras_with_basis|
Stopgaps:
Dependencies: #8678, #16925 |
-------------------------------------+-------------------------------------
Comment (by saliola):
Hello Nicolas,
I'm almost done reviewing this. The patch looks great! I've made some
"improvements" to the documentation, please take a look.
Here are a few remaining questions:
1. First of all, I'm not sure what the commit cfe399d is all about. Was it
some sort of auto-merge by git?
2. `categories/finite_dimensional_modules_with_basis.py`: the docstring of
`quotient_module` talks about quotient "free" module. What do you mean by
free?
3. `categories/semisimple_algebras.py`: what do you mean by "TODO: trivial
implementations for semisimple_quotient"
4. `combinat/free_module.py`: `_order_cmp` requires a docstring
5. `combinat/free_module.py` has a method called `echelon_form`, which is
very similar to `echelonize` from `categories/modules_with_basis.py`. They
essential do the same thing except that `echelon_form` allows one to
specify a `base_ring`. Should these be merged? or eliminate one of them?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=af995f48d7ec6b098eb2115ffb5495e2cc884042
af995f4]||{{{Merge branch 'develop' into
t/11111/more_support_for_finite_dimensional_modules_and_algebras_with_basis}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a476501f8ecfa8784cb7a8a6dfc3d4196f5fe53c
a476501]||{{{Merge branch
'public/11111-more_support_for_finite_dimensional_modules_and_algebras_with_basis'
of trac.sagemath.org:sage into
t/11111/more_support_for_finite_dimensional_modules_and_algebras_with_basis}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/11111#comment:65>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
