#18215: Huge speed up for hash of quadratic number field elements
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  number fields      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/18215                 |  2862b49015b1c47cd0827e72764826e32bdc13e7
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Description changed by vdelecroix:

Old description:

> Before
> {{{
> sage: L.<a> = QuadraticField(-7)
> sage: b = a - 13/7
> sage: timeit("hash(b)")
> 625 loops, best of 3: 54 µs per loop
> }}}
> After
> {{{
> sage: L.<a> = QuadraticField(-7)
> sage: b = a - 13/7
> sage: timeit("hash(b)")
> 625 loops, best of 3: 97.7 ns per loop
> }}}
> ... looks like a x500 speed up :-)
>

> As a consequence (and with #18213 applied)
> Before
> {{{
> sage: %time gr = polytopes.great_rhombicuboctahedron()
> CPU times: user 5.68 s, sys: 68 ms, total: 5.75 s
> Wall time: 5.7 s
> }}}
> After
> {{{
> sage: %time gr = polytopes.great_rhombicuboctahedron()
> CPU times: user 2.71 s, sys: 36 ms, total: 2.75 s
> Wall time: 2.69 s
> }}}

New description:

 Before
 {{{
 sage: L.<a> = QuadraticField(-7)
 sage: b = a - 13/7
 sage: timeit("hash(b)")
 625 loops, best of 3: 54 µs per loop
 }}}
 After
 {{{
 sage: L.<a> = QuadraticField(-7)
 sage: b = a - 13/7
 sage: timeit("hash(b)")
 625 loops, best of 3: 97.7 ns per loop
 }}}
 ... looks like a x500 speed up :-)


 As a consequence (and with #18213 applied)
 Before
 {{{
 sage: %time gr = polytopes.great_rhombicuboctahedron()
 CPU times: user 5.68 s, sys: 68 ms, total: 5.75 s
 Wall time: 5.7 s
 }}}
 After
 {{{
 sage: %time gr = polytopes.great_rhombicuboctahedron()
 CPU times: user 2.71 s, sys: 36 ms, total: 2.75 s
 Wall time: 2.69 s
 }}}

 See also: #18226

--

--
Ticket URL: <http://trac.sagemath.org/ticket/18215#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to