#16820: Implement ABCs for Lie algebras and finite dimensional given by 
structure
cofficients
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  tscrim
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  algebra            |   Resolution:
       Keywords:  lie algebras,      |    Merged in:
  days64                             |    Reviewers:
        Authors:  Travis Scrimshaw   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  8c5361b202dd68b31be6eb414b437badceb3fa76
  public/lie_algebras/fd_structure_coeff-16820|     Stopgaps:
   Dependencies:  #16819             |
-------------------------------------+-------------------------------------
Changes (by darij):

 * milestone:  sage-6.6 => sage-6.7


Comment:

 Replying to [comment:23 tscrim]:
 > It at least covers all 3-dim Lie algebras over char 0 fields (up to
 isomorphism); I will check when I get home what generality they meant (and
 put a reference if you think it's necessary).

 Ah, please add the reference. That's quite an interesting result.

 > Also for this change:
 > {{{#!diff
 > +        if hasattr(self, "module") and x in self.module():
 > +            return self.from_vector(x)
 > }}}
 > I think you should do
 > {{{#!python
 > try:
 >     if x in self.module():
 >         return self.from_vector(x)
 > except AttributeError:
 >     pass
 > }}}

 Does this do something different or is it just more pythonic?
 I am worried about this try-except game as I can't tell whether the
 AttributeError comes from self.module() or from the self.from_vector(x).

 > For the `FromAssociative.lift`...well there's some ambiguity there as to
 whether we want to lift to the UEA or just some enveloping algebra. I
 opted to lift just to the defining algebra (which I forgot to change in
 the docs) as this seemed the most natural. We will also have to deal with
 subalgebras and a `lift` there.

 I am in favor of renaming it then. The abstract `lift` lazy_attribute in
 `sage/categories/lie_algebras.py` explicitly speaks of the UEA in its doc.

 > For the tested methods, it was originally returning an element from a
 matrix Lie algebra, but through refactoring this had changed. This can be
 remedied by changing the 3 to 1, i.e.: `L =
 lie_algebras.three_dimensional_by_rank(QQ, 1)`.
 >
 > I'm also not happy with the corner cases being allowed as all properties
 become vacuous.

 The corner cases need to be allowed, and I've already caught at least 2
 bugs by inserting tests for them.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=8c5361b202dd68b31be6eb414b437badceb3fa76
 8c5361b]||{{{meanwhile, fix _acted_upon_ bug}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16820#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to