#18241: Great speedup in polytopes construction with generic backend
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/18241 | 3c573aef7df1659213bec2614f9ba2b788c1f4fa
Dependencies: #18215 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello,
> Nope. If you call the function with the same `ray` argument you do not
want to recompute it from scratch.
Oh, okay. Then change the cache's name please
> > - I do not like this '_matrix' function very much. Its name is not
very clear (`matrix_from_cached_vector_space`?) but what about just doing
this 'if' twice (it is called twice)?
>
> Me neither. That's why I opened #18231.
Then should it be really fixed inside of this class? Or do we keep this
code as it is and try to solve the #18231 instead.
> The function just constructs a matrix, why the name is badly chosen? You
will get the very same answer as calling `matrix(self.problem.base_ring(),
data)`. Except that it is faster.
Precisely because the name does not reflect the difference.
`matrix_from_cached_vector_space` does.
> What about `.build_matrix` and `.build_matrix_space`?
I hate this class already.
> I do not understand you remark about the `if`.
Oh. Well, because all that 'matrix' does is a if. If it is not a function
of its own, you just have to copy this 'if' around.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18241#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
