#18241: Great speedup in polytopes construction with generic backend
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  geometry           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/18241                 |  3c573aef7df1659213bec2614f9ba2b788c1f4fa
   Dependencies:  #18215             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 About this branch:

 - `zero_set`: why don't you just call `DD.zero_set.clear_cache()` instead
 of rewriting the caching mechanism? If you do want to keep this
 `self.cache` please make the name more specific.

 - `A_matrix` : returns a pointer toward a mutable internal object.

 - Err
   {{{
   Add an inequality to the double description with the inequality ``a``
   added.
   }}}

 - I do not like this '_matrix' function very much. Its name is not very
 clear (`matrix_from_cached_vector_space`?) but what about just doing this
 'if' twice (it is called twice)?

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/18241#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to