#18250: G.triangles_count speedup
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: positive_review
Type: | Milestone: sage-6.7
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Vincent Delecroix
theory | Work issues:
Keywords: | Commit:
Authors: | fd88c98cfc2fee8d0750cd9b6f88d1d7b8177ed4
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/18250 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
> More seriously, I would prefer if the `triangles_count` in
`static_dense_graph` would only accept backend being `static_dense_graph`
(and move the copy step inside the `generic_graph`)
Well.. `generic_graph.py` cannot handle `C` types so it would have
required to move the function to `generic_graph_pyx.pyx` (what a mess
`>_<`), but I think that I was also influenced by the function
`is_strongly_regular` immediately above.
Also, at first this function was building a copy of the graph every time,
because I really did not think that it mattered. There are many functions
like that in `distance_all_pairs` too. It contains every function which
"relies heavily on the distance_all_pairs functions", and most of them
accept Sage graphs directly (though some of them have pure C couterparts).
> I just want to know your feelings about how you would handle
specificities of the backends in the future.
Can you tell me what you mean by "specificities of the backends"?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18250#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
