#18240: fix MPIR's compliance with c++
-------------------------------------+-------------------------------------
Reporter: dimpase | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: packages: | Resolution:
standard | Merged in:
Keywords: | Reviewers:
Authors: Dima Pasechnik | Work issues:
Report Upstream: Reported | Commit:
upstream. Developers acknowledge | d358636766bf0abae69bb07f154053180bd14a8a
bug. | Stopgaps:
Branch: u/dimpase/18240 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by leif):
Replying to [comment:11 dimpase]:
> Replying to [comment:10 leif]:
> > Hmmm, I at least haven't found any reply from Bill on mpir-devel, nor
any related (open or closed) issue on github (wbhart/mpir).
>
> there is a post: https://groups.google.com/d/msg/mpir-
devel/78Hb2-sGrjQ/1VohfbjBmgUJ
> (I suppose that no denial means an acknowledgement)
:-) So this ticket will set itself to "positive review" after a while as
well...
> I just opened an issue on github, too:
https://github.com/wbhart/mpir/issues/153
Ok.
[[BR]]
> > As `mpirxx.h` includes `mpir.h`, is it really necessary to touch the
former as well?
>
> the former need to be touched as `<cstddef>` must be the very 1st
include!
Ok, the real problem is that '''mpirxx.h''' includes mpir.h too late, but
it's not the purpose of this ticket to optimize the order of inclusions in
MPIR's headers.
Still, I'd remove the `/* for size_t */` when including `cstddef`.
Otherwise looks ok to me, but I can't test this right now.
--
Ticket URL: <http://trac.sagemath.org/ticket/18240#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
