#16697: implement symbolic lower incomplete gamma function
-------------------------------------+-------------------------------------
Reporter: rws | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-pending
Component: symbolics | Resolution:
Keywords: gamma, | Merged in:
incomplete, special, functions | Reviewers:
Authors: Ralf Stephan | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5f4a7fbd8598ef3fb22d8cb61d199dfffea23a8c
public/ticket/16697 | Stopgaps:
Dependencies: #17130, |
sympy-0.7.7 |
-------------------------------------+-------------------------------------
Comment (by rws):
Replying to [comment:47 buck]:
> 1. Could one of you point me to the doc pertaining to `_sage_`?
https://github.com/sagemath/sage/blob/master/src/sage/structure/sage_object.pyx#L557
This is overridden where necessary so please see the resp. class. Probably
you want to know about interfaces:
https://github.com/sagemath/sage/blob/master/src/sage/interfaces/interface.py#L803
http://sagemath.org/doc/reference/interfaces/index.html
> 2. There are some
[https://github.com/sagemath/sage/blob/master/src/sage/functions/other.py#L1040-L1056
doctests regarding precision] that have been obliterated. Was this
intentional? Why?
Oh that's true, I don't know why that got ditched.
> 3. It seems like this new function (gamma_inc_lower) would be
deprecated as soon as #17722 is implemented. Don't we want to take a
minute to figure out a design that works for both issues?
There should be no problem to support both interfaces, and without code
duplication. We already have
{{{
sage: incomplete_gamma(1,2)
e^(-2)
sage: gamma(1,2)
e^(-2)
sage: gamma(2)
1
}}}
> I think if this patch implemented lower-gamma as a special case of a
single general gamma function we would end up with less if statements /
edge cases / opportunities for bugs.
Well that's the task for #17722, right. To have many doctests will help a
good deal.
Note that even if you review this ticket (please add ypur realname in the
ticket head in case) we would need to wait for Sympy-0.7.7 to be released.
But a review of the code and the math would leave only a `make ptestlong`
to finish it all.
--
Ticket URL: <http://trac.sagemath.org/ticket/16697#comment:48>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
