#18152: Universal Cyclotomic Field implementation using libgap
-------------------------+-------------------------------------------------
Reporter: | Owner:
vdelecroix | Status: needs_review
Type: | Milestone: sage-6.7
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Jean-Philippe Labbé
number fields | Work issues:
Keywords: | Commit:
Authors: | 29cb0a7663d9303022ce9251534e53a66fac11ec
Vincent Delecroix | Stopgaps:
Report Upstream: N/A |
Branch: |
u/jipilab/18152 |
Dependencies: |
#18153 |
-------------------------+-------------------------------------------------
Changes (by jipilab):
* commit: e4a352468cf9c018b9bdf148a3de03793a111b9e =>
29cb0a7663d9303022ce9251534e53a66fac11ec
* reviewer: => Jean-Philippe Labbé
Comment:
Hi,
So, all test pass on my 6.6.rc3. I went through the files and removed some
trailing spaces and blank lines.
Replying to [comment:28 28]: I do not have a use case for sparse
cyclotomic out of my head. It is also difficult to guess for the use I
have in mind (mainly representation of Coxeter groups). Nonetheless, the
matrices will not have large conductor. Thus I would say it is not too bad
as it is for the purpose of Coxeter groups.
Going through the discussion, the current state of affairs is:
The following tickets are fixed:
#14240, #16130, #16631, #17117
The following tickets are follow-ups:
#16116,#18207
The ticket looks good to me. It is well doctested with many examples. I
would put positive review, nevertheless it would be good if someone else
also go over the ticket too, Christian?
Best,
JP
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=591409b3d074fff8bff7dad14be97ce02851ca94
591409b]||{{{Merge branch 'develop' into cyclotomic}}}||
||[http://git.sagemath.org/sage.git/commit/?id=29cb0a7663d9303022ce9251534e53a66fac11ec
29cb0a7]||{{{Corrected some blank lines and trailing spaces}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18152#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
