#18152: Universal Cyclotomic Field implementation using libgap
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.7
      Component:  number fields      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:  Jean-Philippe Labbé
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/18152                 |  b8e369b03f2f444c6af07b77038610e43e625db8
   Dependencies:  #18153             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * commit:  29cb0a7663d9303022ce9251534e53a66fac11ec =>
     b8e369b03f2f444c6af07b77038610e43e625db8
 * branch:  u/jipilab/18152 => u/vdelecroix/18152


Comment:

 Salut Jean-Phillippe,

 Thanks for your corrections! The branch is a fast forward. So you have to
 delete your previous branch. Your commit is preserved (it is now 08df5b4).
 I added three commits for better compatibility with the previous version:
  - adding a `minpoly` and `field_order` methods as it was requested in
 [comment:23 comment:23] (see also #18266 for a potential improvement)
  - adding a `__neg__` (it is now faster to do `-E(3)`)

 Vincent
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=0c8af9b33e2e51e5515325529ea4f419ecd8a894
 0c8af9b]||{{{Trac 18152: universal cyclotomic field using libgap}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=509acf7d0c129da220729e914b50d895316f300f
 509acf7]||{{{Trac 18152: remove the old implementation}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=519dc00a585ca5f9ac000557e6151c5eec990e12
 519dc00]||{{{Trac 18152: Fix coxeter group import}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=08df5b48a236a18a3b37faf513e93d16df4145b9
 08df5b4]||{{{Corrected some blank lines and trailing spaces}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=890151f42c0073f067724c42378969aa9d589723
 890151f]||{{{Trac 18152: add a minpoly method to UCF elements}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=70f78956a802b89c22dafebf02ca5016856baca5
 70f7895]||{{{Trac 18152: field_order as a deprecated alias of
 conductor}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=b8e369b03f2f444c6af07b77038610e43e625db8
 b8e369b]||{{{Trac 18152: __neg__ for UCF elements}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18152#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to