#18295: random SSYT
-------------------------------------+-------------------------------------
       Reporter:  deinst             |        Owner:  deinst
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.7
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Einstein     |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/deinst/random_ssyt               |  71db228b662f07cd424ebdd5c11e4b8d019fc0c1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * commit:   => 71db228b662f07cd424ebdd5c11e4b8d019fc0c1
 * reviewer:   => Travis Scrimshaw


Comment:

 One bigger thing is that it seems like the description of the
 `SemistandardTableaux(6, max_entry=7).random_element()` was cutoff. Some
 smaller things:

 - Instead of code formatting, use the link:
 {{{:class:`SemistandardTableau`}}}.
 - The `\t` is interpreted by python/sphinx as a tab character. To work
 around this, make the string a so-called "raw" string, start the docstring
 by `r"""`.
 - The first sentence should be declarative: `Return` instead of `Returns`.
 - In python, you don't need the parenthesis here: `while (randpos >=
 tot):`.
 - Make `max_entry` in code formatting: {{{``max_entry``}}}.
 - Link to references by adding a trailing underscore: `[Krat99]_`.
 - Could you make sure there's no trailing whitespace?

 Looks good otherwise. Thanks.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=c089c09c551d50ec9b4cbd9889f74f631ef12f61
 c089c09]||{{{Added random element functions to Semistandard Tableaux}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=71db228b662f07cd424ebdd5c11e4b8d019fc0c1
 71db228]||{{{Merge branch 'random_ssyt' into t/18295/random_ssyt}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18295#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to