#15375: Extended Affine Weyl Groups SD40
-------------------------------------+-------------------------------------
Reporter: bump | Owner: bump
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.7
Component: combinatorics | Resolution:
Keywords: days54, coxeter, | Merged in:
days64 | Reviewers: bump
Authors: Daniel Bump, Dan | Work issues:
Orr, Anne Schilling, Mark | Commit:
Shimozono, Nicolas Thiery. | ecfe8e2d164710fdf9957be6c47588cfb9d73cbc
Report Upstream: N/A | Stopgaps:
Branch: |
public/combinat/extended_affine_weyl_groups-15375|
Dependencies: #10963, #14102 |
-------------------------------------+-------------------------------------
Comment (by aschilling):
Here are some comments on the patch. Mark, can you work on them so we can
review them?
- There are several methods in `ExtendedAffineWeylGroup_Class` that do not
have documentation or tests.
- I remember that we talked about this at Sage Days 64: can we get rid of
`to_ambient` in all the various places?
- `fundamental_groups.py` also does not have full documentation coverage!
- Also
{{{
pyflakes extended_affine_weyl_group.py
extended_affine_weyl_group.py:940: undefined name 'Infinity'
}}}
- Many methods in `sage.groups.group_semidirect_product.py` have no
documentation.
Best,
Anne
--
Ticket URL: <http://trac.sagemath.org/ticket/15375#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
