#18311: Improve radical_basis and cartan_invariants_matrix for a finite 
dimensional
algebra
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.7
      Component:  algebra            |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Nicolas M. ThiƩry  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/nthiery/representation_theory/finite_dimensional_algebras-18311|  
50867d895544ee5a449423bde74440ea8470f9ee
   Dependencies:  #18310, #6484      |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by virmaux):

 Hello,

 I just took some time to read the patch.

 `FiniteDimensionalAlgebrasWithBasis.multiplication_matrix` the name is not
 very explicit, what about `basis_action_matrices` ? As well, wether we
 want sparse matrices or not may be given as an argument?

 Should we overwrite the previous method for Cartan invariant matrix from
 #16659 with this new one ? Indeed the return should be the same and it's
 much faster! In this case maybe we may want to wait that #16659 is
 positive_reviewed to avoid merging issues.

 Everything else looks good to me (modulo the remaining documentation)
 I can do the aforementioned modifications.

--
Ticket URL: <http://trac.sagemath.org/ticket/18311#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to