#18344: fix some case issues in sage-fix-pkg-checksums
-------------------------+-------------------------------------------------
Reporter: | Owner:
jhpalmieri | Status: needs_review
Type: | Milestone: sage-6.7
defect | Resolution:
Priority: major | Merged in:
Component: build | Reviewers:
Keywords: | Work issues:
Authors: John | Commit:
Palmieri | 02ba7045cf38725ca8cb5456df649b6bacdcbd8e
Report Upstream: N/A | Stopgaps:
Branch: |
u/jhpalmieri/case |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by leif):
While your patch apparently fixes the issue ''with uppercase letters'' in
upstream tarballs (haven't tested it yet though), I don't like the concept
of the script, which is pretty upside-down: Instead of iterating over
`build/pkgs/*` and taking the name of the upstream tarball from there, it
does the opposite.
I'd rather have
`sage-pkg-checksums [--verbose] [--create|--check|--update] [<package
name>]*`
with useful information about missing upstream tarballs, checksum
mismatches etc., but that's presumably beyond this ticket.
(And we have a wild mixture of `tr`, `sed`, `shopt -s nocaseglob`, and
shell parameter expansion in various shell scripts... The Python script
`sage-pkg` also seems to be obsolete or at least not yet suited for "new
style" spkgs.)
--
Ticket URL: <http://trac.sagemath.org/ticket/18344#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
