#15635: free Pre-Lie algebras
-------------------------------------+-------------------------------------
Reporter: chapoton | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: combinatorics | Resolution:
Keywords: trees, prelie | Merged in:
algebra | Reviewers: Travis Scrimshaw
Authors: Frédéric Chapoton | Work issues:
Report Upstream: N/A | Commit:
Branch: | c833a235630124d7ad4303561ed57faad08335f2
u/tscrim/free_pre_lie-15635 | Stopgaps:
Dependencies: #11529 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: c42ba5a40ebc5b6dc5709aa6046ffcc066c24d18 =>
c833a235630124d7ad4303561ed57faad08335f2
* work_issues: coercion =>
* branch: u/chapoton/15635 => u/tscrim/free_pre_lie-15635
* reviewer: => Travis Scrimshaw
Comment:
I made some review changes:
- I added `algebras.FreePreLie` and made this the standard entry point.
- I moved the main explanation doc from the module level to the class. I
also made some minor tweaks to the doc overall.
- I also renamed the file by removing the `s` as this is the standard in
Sage AFAIK.
- I changed the output of `algebra_generators` as per my previous point.
The ordering should be consistent as this was something we changed awhile
ago.
- Subsequently, I changed around some things so that it works with
infinite generating sets.
- I changed the `some_elements` and implemented an `an_element` method.
If you're happy with my changes, then you can set a positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=da67955b266a3a12dd7479fe69768df8d73a013d
da67955]||{{{Reviewer changes to free pre-Lie algebras.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=97c33127c831f32dbd94a52473bbe4809f2a22f1
97c3312]||{{{Changed the output of algebra_generators().}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c833a235630124d7ad4303561ed57faad08335f2
c833a23]||{{{Adding support for infinite indexing sets.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15635#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
