#15635: free Pre-Lie algebras
-------------------------------------+-------------------------------------
Reporter: chapoton | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: combinatorics | Resolution:
Keywords: trees, prelie | Merged in:
algebra | Reviewers: Travis Scrimshaw
Authors: Frédéric Chapoton | Work issues:
Report Upstream: N/A | Commit:
Branch: | c833a235630124d7ad4303561ed57faad08335f2
u/tscrim/free_pre_lie-15635 | Stopgaps:
Dependencies: #11529 |
-------------------------------------+-------------------------------------
Comment (by chapoton):
Thanks a lot for your work on that ticket. I have not yet got time to look
at your changes seriously.
> - I added `algebras.FreePreLie` and made this the standard entry point.
'''I do not quite agree'''. Most people would not call them algebras,
because they are NOT associative
> - I moved the main explanation doc from the module level to the class. I
also made some minor tweaks to the doc overall.
> - I also renamed the file by removing the `s` as this is the standard in
Sage AFAIK.
No problem with removing s
> - I changed the output of `algebra_generators` as per my previous point.
The ordering should be consistent as this was something we changed awhile
ago.
> - Subsequently, I changed around some things so that it works with
infinite generating sets.
Great !
> - I changed the `some_elements` and implemented an `an_element` method.
>
> If you're happy with my changes, then you can set a positive review.
The first point is problematic in my opinion.
> PS/EDIT - It would be nice to have the trees with specified labels, as
this would allow the generic implementation of `an_element` and removing
of the `_alphabet` parameter (well, pushing it down a level).
yes, I agree !
--
Ticket URL: <http://trac.sagemath.org/ticket/15635#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
